Fix proposal vote percentage calculation#228
Open
shashankvaishnav wants to merge 1 commit into
Open
Conversation
Author
|
Hi maintainers, I opened this PR for #184. The fix avoids assuming all three vote_count entries exist and instead sums the vote_count rows returned by the chain table. This should handle older proposals like proposal #1 where zero-value vote types were not stored. Could you review when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184.
This updates the vote percentage calculation to sum the available vote_count rows instead of assuming all three vote types are present. Older proposals can omit vote types with zero weight, which caused proposal #1 to fail when the UI accessed a missing array entry.
Validation: